DOC: extending README.md with the development section#61
DOC: extending README.md with the development section#61mrakitin wants to merge 1 commit intojupyterlab:mainfrom
Conversation
ian-r-rose
left a comment
ian-r-rose
left a comment
There was a problem hiding this comment.
Thanks @mrakitin! I just had one minor comment.
| ```bash | ||
| jupyter lab --watch | ||
| ``` | ||
| This will automatically recompile `@jupyterlab/github` upon changes, and |
There was a problem hiding this comment.
The jupyter lab --watch process won't automatically recompile the extension typescript sources, it instead watches the built JS. So you still need to watch or recompile the extension for JupyterLab to pick up the changes.
There was a problem hiding this comment.
Thanks for the review, @ian-r-rose! What would you recommend then? jupyter lab --watch --dev-mode? Or another step for recompilation?
There was a problem hiding this comment.
Not --dev-mode (which will run JupyterLab from master without extensions). Instead we can start a watch process in the jupyterlab-github directory (jlpm run watch), which will recompile the extension at the same time as the jupyter lab --watch process is going on, which will then pick up the changes to the compiled sources.
2 participants
I noticed that there is no
Developmentsection in the README.md file. This PR attempts to fix it (based on jupyterlab-google-drive and a little on ipysheet).